I suspect that i < this.size() - 1 was used to assure that we're always comparing point i to point i+1. However, as you point out in #62 this prevents the final data point in a spectrum from being included, which will remove the point if it is a 1+ ion. I'll merge in this pull request then run some tests of my own to see what kind of ID rate changes I see.
DennisGoldfarb
commented
5 years ago
I suspect that
i < this.size() - 1was used to assure that we're always comparing point i to point i+1. However, as you point out in #62 this prevents the final data point in a spectrum from being included, which will remove the point if it is a 1+ ion. I'll merge in this pull request then run some tests of my own to see what kind of ID rate changes I see.