MSGFPlus / msgfplus

MS-GF+ (aka MSGF+ or MSGFPlus) performs peptide identification by scoring MS/MS spectra against peptides derived from a protein sequence database.
Other
73 stars 36 forks source link

-maxMissedCleavages not showing in mzIdentML #72

Closed detritus closed 4 years ago

detritus commented 5 years ago

Tested in: Release (v2019.07.03)

When specifying -maxMissedCleavages 1, the value is not being output in the mzIdentML:

Actual: <Enzyme semiSpecific="false" missedCleavages="1000" id="Tryp"> Expected: <Enzyme semiSpecific="false" missedCleavages="1" id="Tryp">

From a glance at the data, it seems the value set is being used, it is only the the missedCleavage attribute that is not being written correctly.

FarmGeek4Life commented 5 years ago

Well, this line says you are probably 100% correct.

FarmGeek4Life commented 5 years ago

Commit c7fd191 is a fix for this, so the next release will resolve this issue.

detritus commented 5 years ago

Thanks @FarmGeek4Life. Glad to know the issue is only cosmetic. :)