MSKCC-Epi-Bio / bstfun

Miscellaneous collection of functions
http://mskcc-epi-bio.github.io/bstfun
Other
34 stars 24 forks source link

gtExtras sparkline #101

Closed jthomasmock closed 2 years ago

jthomasmock commented 2 years ago

Hi @ddsjoberg - I realize that I forgot to tell you that gtExtras::gt_plt_dist() exists and will likely be the replacement for the more general gt_sparkline() function.

See: https://jthomasmock.github.io/gtExtras/reference/gt_plt_dist.html

Specifically for your use, when I move to CRAN, I'll likely be removing gt_sparkline() in favor of:

To an extent, you should be able to replace gt_sparkline() with gt_plt_dist() but wanted to note the difference, deprecation, and open conversation before I removed the code.

webshot2 is on CRAN now (🚀 ) so I am inching closer to an initial CRAN release of gtEtxras.

ddsjoberg commented 2 years ago

Thank you for the heads up!

I can go ahead and update my code to use the gt_plt_*() functions now, right?

Once gtExtras is on CRAN, i'll also update the DESCRIPTION file to depend on CRAN instead of GH.

jthomasmock commented 2 years ago

I can go ahead and update my code to use the gt_plt_*() functions now, right?

Once gtExtras is on CRAN, i'll also update the DESCRIPTION file to depend on CRAN instead of GH.

Yes, the gt_plt_dist() and gt_plt_sparkline() have been around for a bit, I just forgot to give you a heads up!

Let me know if you run into any testing failures from the switch, but they should be drop-in replacements (just splitting out the sparkline "lines" vs inline distributions graph types)

jthomasmock commented 2 years ago

Thanks! I'm going to go ahead and remove gt_sparkline() from the package.