search

MSKCC-Epi-Bio / bstfun

Miscellaneous collection of functions
http://mskcc-epi-bio.github.io/bstfun
Other
34 stars 24 forks source link

Feature request: Allow bolding and italicizing for group's headers #65

Closed oranwutang closed 2 years ago

oranwutang commented 3 years ago

Hi there!

In stacked tables there is an option to add headers for each table (group_header argument in tbl_stack()), but those labels can't be easily modified to set them in bold or italics. It would be nice to have a function like:

stacked_table %>% bold_groupheaders()

Similar to bold_labels()

Thanks in advance and best regards!

ddsjoberg commented 3 years ago

Hello @oranwutang ! I hope and your family are well!

I like the idea for sure. I do have some other plans for the group headers in the pipeline, however. To avoid conflicts, let's implement this function in bstfun first, and we can migrate it to gtsummary.

Do you want to take a stab at the new function, or do you want to wait until I get around to it ( I may not have time for a while, to be honest). If you want to write it, let's outline it together before you start programming?

oranwutang commented 3 years ago

Hi @ddsjoberg! We're fine, thanks!

I'll take the challenge, you know I'm glad to collaborate with you and your team.

Please send me an email with your thoughts about groups headers, I think I'll need some guidance, tho...

In the meantime I'll try to get acquainted with btsfun

ddsjoberg commented 3 years ago

Great!

Can you open a pull request into bstfun with a new function bold_group_labels()? The script can be empty and we can continue the conversation on GitHub PR page! Thanks @oranwutang !

ddsjoberg commented 2 years ago

merged!