MSKCC-Epi-Bio / gnomeR

Package to wrangle and visualize genomic data in R
https://mskcc-epi-bio.github.io/gnomeR/
Other
26 stars 19 forks source link

make `tbl_genomic` an official 'gtsummary' table #174

Closed michaelcurry1123 closed 2 years ago

michaelcurry1123 commented 2 years ago
michaelcurry1123 commented 2 years ago

Dan said to make it an official 'gtsummary' table all you need to do is append your own class to the front of the class like so: class(df_tbl) <- c("tbl_genomic", class(df_tbl)). Then from here if we wanted to create a tbl_genomic method we can and the classes will be in the proper order. I can add it to the function tbl_genomic().

michaelcurry1123 commented 2 years ago

might want to remove bold_labels and add_overall from internals of tbl_genomic and just allow the user to specify.

karissawhiting commented 2 years ago

@michaelcurry1123 can we close this?

michaelcurry1123 commented 2 years ago

@karissawhiting yes we can close!