MSKCC-Epi-Bio / gnomeR

Package to wrangle and visualize genomic data in R
https://mskcc-epi-bio.github.io/gnomeR/
Other
26 stars 19 forks source link

added better error messages for sample_id error #236

Closed michaelcurry1123 closed 1 year ago

michaelcurry1123 commented 1 year ago

What changes are proposed in this pull request?

sample_id is a column not a row label anymore. had to update internal function tests to reflect this change If there is an GitHub issue associated with this pull request, please provide link.

resolves #204

Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged into master:

karissawhiting commented 1 year ago

@michaelcurry1123

I decided to add a utils function that checks for required columns so it can be used in all functions. I added it to utils.R and then used it in the sanitize functions as well as the functions in this PR.

Could you give it a quick test?

Thanks for finding these!

michaelcurry1123 commented 1 year ago

No problem will do!

michaelcurry1123 commented 1 year ago

@karissawhiting just tested all ran well no errors on my computer!