Closed michaelcurry1123 closed 1 year ago
@michaelcurry1123
I decided to add a utils function that checks for required columns so it can be used in all functions. I added it to utils.R
and then used it in the sanitize functions as well as the functions in this PR.
Could you give it a quick test?
Thanks for finding these!
No problem will do!
@karissawhiting just tested all ran well no errors on my computer!
What changes are proposed in this pull request?
sample_id is a column not a row label anymore. had to update internal function tests to reflect this change If there is an GitHub issue associated with this pull request, please provide link.
resolves #204
Reviewer Checklist (if item does not apply, mark is as complete)
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# cbioportalR (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).codemetar::write_codemeta()
usethis::use_spell_check()
again