Open alrein-05 opened 1 year ago
Comments from old PR:
@alrein-05 This looks really good! Thanks very much for adding :)
I think next steps include:
- Adding an Introduction section explaining when/ why someone would want to analyze copy number data and stating the aim of the vignette (do you have a reference paper we can add with an example of a good CNA analysis? Doesn't have to be MSK). This could be combined with your current 'What are copy number alterations' section.
- Expanding outline into more descriptive sections in the style of the other vignette: https://mskcc-epi-bio.github.io/gnomeR/articles/data-processing-vignette.html
- Adding some code and an example working through seg data for users to follow along in the vignette. For now we can use the example seg file in the package:
gnomeR::seg
- Are there any additional types of analysis you do on this data after you create heatmaps? Hannah and I can share the workflow outline Caroline gave us and we can add from there as well.
Do you have time/interest to continue with these updates? We'd love your continued input but if not, no worries. @hfuchs5 and I can take over.
Thanks again for your great work!
Added example heatmap under CNA_vignette
What changes are proposed in this pull request? Added an example heatmap for copy number segmentation data
If there is an GitHub issue associated with this pull request, please provide link.
258
Reviewer Checklist (if item does not apply, mark is as complete)
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# cbioportalR (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).codemetar::write_codemeta()
usethis::use_spell_check()
again