MSKCC-Epi-Bio / gnomeR

Package to wrangle and visualize genomic data in R
https://mskcc-epi-bio.github.io/gnomeR/
Other
26 stars 16 forks source link

Copy Number Alteration Vignette #297

Open alrein-05 opened 1 year ago

alrein-05 commented 1 year ago

Added example heatmap under CNA_vignette

What changes are proposed in this pull request? Added an example heatmap for copy number segmentation data

If there is an GitHub issue associated with this pull request, please provide link.

258


Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged into master:

karissawhiting commented 1 year ago

Comments from old PR:

@alrein-05 This looks really good! Thanks very much for adding :)

I think next steps include:

  • Adding an Introduction section explaining when/ why someone would want to analyze copy number data and stating the aim of the vignette (do you have a reference paper we can add with an example of a good CNA analysis? Doesn't have to be MSK). This could be combined with your current 'What are copy number alterations' section.
  • Expanding outline into more descriptive sections in the style of the other vignette: https://mskcc-epi-bio.github.io/gnomeR/articles/data-processing-vignette.html
  • Adding some code and an example working through seg data for users to follow along in the vignette. For now we can use the example seg file in the package: gnomeR::seg
  • Are there any additional types of analysis you do on this data after you create heatmaps? Hannah and I can share the workflow outline Caroline gave us and we can add from there as well.

Do you have time/interest to continue with these updates? We'd love your continued input but if not, no worries. @hfuchs5 and I can take over.

Thanks again for your great work!