Closed hfuchs5 closed 11 months ago
This looks good and close to merge!
I think we can simply the .check_numeric()
function a bit. We can either stick to base R matrix subsetting (is_numeric <- apply(alt_only, 2, is.numeric)
, then names(is_numeric[!is_numeric])
), or if we want tidyverse I think imap()
would be a good option. This maps over input columns and names simultaneously. Then I don't think we would need to create the interstitial dataframe in between input and outputting vector of names for messaging, which I think could slow things down on a large data set.
What changes are proposed in this pull request? Changed non-numeric column identification to make sure it stopped printing all of the column names
If there is an GitHub issue associated with this pull request, please provide link.
314
Reviewer Checklist (if item does not apply, mark is as complete)
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# cbioportalR (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).codemetar::write_codemeta()
usethis::use_spell_check()
again