MSKCC-Epi-Bio / gnomeR

Package to wrangle and visualize genomic data in R
https://mskcc-epi-bio.github.io/gnomeR/
Other
26 stars 16 forks source link

Internal colname messages #324

Closed karissawhiting closed 11 months ago

karissawhiting commented 11 months ago

What changes are proposed in this pull request?

Update internal processing of input data set names. Currently any passed genomic data is resolved to a set of internal data field names for all functions. This makes it confusing when warnings are thrown using internal assigned names, not original data set names.

If there is an GitHub issue associated with this pull request, please provide link.

302


Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged into master:

karissawhiting commented 11 months ago

@hfuchs5 - Could you double check there aren't any spots where I missed this column name replacement? I updated it in sanitize data functions and also create_gene_binary()

Also if you could stress test it a little more that would be great as I did end up changing quite a few internals. Thank you!!!!