Closed karissawhiting closed 11 months ago
@hfuchs5 - Could you double check there aren't any spots where I missed this column name replacement? I updated it in sanitize data functions and also create_gene_binary()
Also if you could stress test it a little more that would be great as I did end up changing quite a few internals. Thank you!!!!
What changes are proposed in this pull request?
Update internal processing of input data set names. Currently any passed genomic data is resolved to a set of internal data field names for all functions. This makes it confusing when warnings are thrown using internal assigned names, not original data set names.
If there is an GitHub issue associated with this pull request, please provide link.
302
Reviewer Checklist (if item does not apply, mark is as complete)
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# cbioportalR (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).codemetar::write_codemeta()
usethis::use_spell_check()
again