MSO4SC / cloudify-hpc-plugin

Plugin to allow Cloudify to deploy and orchestrate HPC resources
Apache License 2.0
8 stars 8 forks source link

feature request: add a post step #75

Closed Trophime closed 6 years ago

Trophime commented 6 years ago

Would it be possible to have the same kind of -pre feature that @victorsndvg implemented for monitoring for post-processing?

Typical use case would be:

victorsndvg commented 6 years ago

Maybe @emepetres can add more details here.

He was the one who implement the pre command list, but also a post command list after the heavy simulation command and inside the sbatch script.

@Trophime , maybe this option already solves your requirements?

Trophime commented 6 years ago

I was not aware of that command. Is there some examples of the post command?

victorsndvg commented 6 years ago

There are no examples. The usage is the same as the pre option. A list of shell commands to be executed befor(pre)/after(post) the command.

Here is in the docs: https://github.com/MSO4SC/cloudify-hpc-plugin/tree/canary#hpcnodessingularityjob

You can take the pre example here: https://github.com/MSO4SC/resources/blob/master/blueprint-examples/single-singularity-logger/blueprint.yaml#L71

If you need I can update a blueprint-example to include the post feature

Trophime commented 6 years ago

thanks 👍

victorsndvg commented 6 years ago

@Trophime , finally I found where it is implemented:

https://github.com/MSO4SC/cloudify-hpc-plugin/blob/canary/hpc_plugin/workload_managers/slurm.py#L66

Note that only SingularityJobs support it!