search

MSP-Greg / ruby-loco

Fully tested Ruby Windows Mingw, ucrt & mswin builds, built and saved on GitHub
https://github.com/MSP-Greg/ruby-loco
MIT License
17 stars 5 forks source link

Update OpenSSL env variables for mswin builds only when necessary #14

Closed rhenium closed 2 months ago

rhenium commented 2 months ago

Do not try to set those environment variables if they are already set by the user.

I'm writing a test for https://github.com/ruby/openssl that wants to use a custom OPENSSL_CONF environment variable, and it currently fails on ruby/setup-ruby mswin, seemingly because the file is not read by OpenSSL: https://github.com/rhenium/ruby-openssl/commit/140eaabb3f650590736cc818333e4f208e427d6b

I'm guessing this change would fix it, but I haven't tested it myself. Could you review?

MSP-Greg commented 2 months ago

@rhenium

LGTM. It's generating a new build now...

rhenium commented 2 months ago

The latest mswin build fixed it for me. https://github.com/ruby/openssl/actions/runs/9485370958/job/26141247177?pr=767

Thank you!

MSP-Greg commented 2 months ago

Glad that worked, and thanks for the PR. I was going to ping you when the build finished, but I thought it was 1:30 A your time?