search

MSP-Greg / ruby-loco

Fully tested Ruby Windows Mingw, ucrt & mswin builds, built and saved on GitHub
https://github.com/MSP-Greg/ruby-loco
MIT License
17 stars 5 forks source link

Frozon spec.metadata["msys2_mingw_dependencies"] value doesn't work #4

Closed kou closed 3 years ago

kou commented 3 years ago

Because https://github.com/MSP-Greg/ruby-loco/blob/master/patches/__operating_system.rb.patch#L21 uses String#sub!. Can we use deps = deps.sub(d, '') here?

An error output: https://github.com/ruby/fiddle/runs/1408885075?check_suite_focus=true

MSP-Greg commented 3 years ago

@kou

Sorry about that. Fixed, it will take ~ 45-50 minutes for a new build.

I added it a long time ago, maybe I can remove it, but it helped with testing against a custom package.

For instance, testing against OpenSSL 3.0 when the 'proper' MSYS2 package is 1.1.1. I know Lars made some changes recently...

kou commented 3 years ago

Wow! Thanks for your quick fix! I've confirmed that this has been fixed.

MSP-Greg commented 3 years ago

And thanks for your quick check. I was just updating my fiddle repo and about to run CI...