MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 6 forks source link

Some maps crash on LAN #108

Closed SaintWish closed 1 year ago

SaintWish commented 1 year ago

This doesn't seem to affect dedicated servers at all.

Some maps like kroush will crash when you use map command or use the main menu to load into them, however changelevel doesn't cause this.

SaintWish commented 1 year ago

From age

so the map crashing on LAN issue has to be a memory issue or something, because I can actually load directly into kroush and dragooncaves once on a local server [16:47] if i change back to kroush at any time without restarting the game it will crash, out of like 30+ attempts i got it to load twice but that was map kroush > almost instant changelevel kroush at char select, dragooncaves is a little more forgiving [16:49] tried random shit like fullscreen instead of borderless, sv_lan 0 and 1, bouncing to edana and back, could even go kroush > dragooncaves but NOT dragooncaves>kroush [16:49] in fact going dragooncaves>kroush is the only thing that gives me an actual error,

error

SaintWish commented 1 year ago

When I tried loaded into dragooncaves first time on LAN server then tried votemap to kroush afterwards I got some memory errors in the server log. https://hastebin.com/edegogimob.rb

However when I try to load into aleyesu first time on a LAN server I get exited to desktop with no memory errors in the server log the last line was [INFO]: World Activate in via server log.

SaintWish commented 1 year ago

This is caused by the engine limitations we've ran into I think since it seems LAN servers don't use rehlds like dedicated servers do. Though I could be wrong; requires more testing to confirm...

SaintWish commented 1 year ago

We no longer use COM_LoadFile except for some scripting systems, so this issue should be resolved.