MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 6 forks source link

Spawn block prevention and Accuracy replaced with Crit system that does not break thunder misses. #147

Closed Aze-M closed 1 year ago

Aze-M commented 1 year ago

Spawn blocking

Players now spawn as SOLID_NOT until 124 units away from spawn and other players; This should prevent places like gatecity spawnlocking with more than one person due to lack of spawnpoints;

Accuracy

Attacks can no longer miss under normal circumstances. All attack rolls are hidden as the only way to miss is to be under an ailment that reduces your hit chance like lightning. Monsters can still miss as they are handled elsewhere.

Critical hits.

Critical hits have been implemented for both players and monsters, monsters do not get default crit where as all weapons unless otherwise defined have a crit threshold of 95 and a crit multiplier of 1.5. Accesible in scripts via: reg.attack.critthreshold ( the number that needs to be rolled higher, 100 for disabled criticals ); reg.attack.critmulti (the amount to multiply by on critical hit);

Oddities

Due to the way hits are calculated right now this will cause weapons with less crit chance than the lightning debuffs accuracy penalty to be unable to crit as they will miss. Unlikely to cause any real issues but needs testing and potential adjustments.

Note

The branch this was forked from does not run the game (Exit Code : 0) but both systems were tested with an older fork.

Related Issues

143

133

Aze-M commented 1 year ago

To Clarify on the the game not running off of this fork: I was using an older Fork from Feb 1 where the saving doesnt work which was used to test both systems, Then pulled to the fork going up to date and tested which caused the gamae to no longer run but also not throw any critical exception.

Aze-M commented 1 year ago

Miss logic was inversed to make misses occur on low hits when affected by lightning, so crits are still possible.