MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 6 forks source link

Replace mslist with std vector and msstring with std string #179

Open SaintWish opened 1 year ago

SaintWish commented 1 year ago

This should be done after angelscript is embedded.

Aze-M commented 1 year ago

I believe MSLists are a custom implementation of a linked list rather than a vector, would have to look into which is more efficient for our purposes.

SaintWish commented 1 year ago

From what I was reading traditional linked lists are bad for reading random data inside, so in such a case a vector would be better. Though I'm not sure if such would apply to mslist list since it's a custom implementation, though it might be worth it to just switch to std list in such a case.

Here's a future note: differences between vector and std list https://stackoverflow.com/questions/2209224/vector-vs-list-in-stl#2209564

Anyways, I did start doing this but I reverted it. I figured we should probably wait for angelscript to avoid breaking the already fragile scripting system.