MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 6 forks source link

feat: refactor funcmonsterclip and add funcplayerclip #212

Closed thesupersoup closed 1 year ago

thesupersoup commented 1 year ago

Should close issue https://github.com/MSRevive/MasterSwordRebirth/issues/207

Paired with PR https://github.com/MSRevive/assets/pull/12 in assets

Changed CFuncMonsterClip to be a CFuncWallToggle (to mask it in case any engine level code is looking for FuncWallToggles) and overrode all class methods. Hopefully works just like a func_wall_toggle without the hacky origin teleportation to turn on and off. Should always be passable to players.

Added CFuncPlayerClip, which works sort of like a func_wall_toggle. If the player touches it, it becomes solid. If a monster touches it, it becomes passable. It should push players back out of it scaled to the dmg amount of the brush, which I believe means it will be a mapper-side configurable value.

Both still need testing but I thought at least the review process could begin with them in a PR.