MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 6 forks source link

Fix Player Colormap / Add to Options Menu #238

Open frendship-loost opened 3 months ago

frendship-loost commented 3 months ago

By default, our config.cfg has entries for player color-remapping. These are not used in-game for player model rendering it appears, and the sliders to set these values have been removed from the options menu. From looking through studiomodelrenderer.cpp, I believe that the function that enables color-remapping has been removed or never added to our codebase. The default HLSDK found in github contains code from TFC that enables the original support for this.

Valve Goldsrc SDK: https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/cl_dll/StudioModelRenderer.cpp#L1106

Default config.cfg values found in MSR: bottomcolor "6" topcolor "30"

greatguys1 commented 3 months ago

The colormap was highjacked to use render flags instead, so its not as simple as just enabling the feature. Many systems seem to depend on these flags, and undoing it will take quite some effort.