search

MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.
https://msrebirth.net/
Other
9 stars 7 forks source link

Overflow for client and server on ms_snow #54

Closed SaintWish closed 2 years ago

SaintWish commented 2 years ago

Randomly when playing ms_snow the client can overflow, especially with character data that is extremely large (like fegged's testing character)

SZ_GetSpace: overflow on netchan->message
WARNING: reliable overflow for Wishbone
Dropped Wishbone from server
Reason:  Reliable channel overflowed

The server can also crash by some overflow as well randomly

SZ_GetSpace: overflow on netchan->message
SZ_GetSpace: overflow on netchan->message
FATAL ERROR (shutting down): SZ_GetSpace: overflow without FSB_ALLOWOVERFLOW set on Server Reliable Datagram

Is this a map issue and engine limitation issue, though I'm not sure why?

SaintWish commented 2 years ago

Seems to be fixed with this commit https://github.com/MSRevive/MasterSwordRebirth/commit/173cdbbd47a900bd18f3168ed703d76f5f9a446c