FN server crashes if there's no character data

MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.

https://msrebirth.net/

Other

9 stars 6 forks source link

FN server crashes if there's no character data #71

Closed SaintWish closed 2 years ago

SaintWish commented 2 years ago

Basically any server connected to via FN will crash if a new player joins without any FN data. This is what caused MSRevive/MasterSwordRebirth#69.

SaintWish commented 2 years ago

[API] INFO: 2022/06/24 22:10:13.402391 GET /api/v1/character/76561198213264697/2 from 172.18.0.1 (542.676µs)
[API] DEBUG: 22:10:13.405955 middleware.go:118: Useragent: 
[API] ERROR: 2022/06/24 22:10:13.406108 character.go:73: ent: character not found
[API] INFO: 2022/06/24 22:10:13.406192 GET /api/v1/character/76561198213264697/1 from 172.18.0.1 (237.313µs)

It seems when the FN server encounters a error it will break the game server.

SaintWish commented 2 years ago

This was fix on the game side with https://github.com/MSRevive/MasterSwordRebirth/commit/b400914e407fb8b80c08c82953aec066046ec307