MSTC-DA-IICT / B-for-Blog

Hacktoberfest 2021

MIT License

2 stars 10 forks source link

Code upgraded with hyperlinks in navbar #11

Closed Anik-Bardhan closed 3 years ago

Anik-Bardhan commented 3 years ago

1 issue solved.

Things upgraded are listed below:

[x] created layout.html for base template
[x] implemented layout.html in all other html
[x] added logout.html as the file was missing
[x] hyperlinks to home added
[x] hyperlinks to login page added
[x] hyperlinks to create blog added
[x] hyperlinks to logout added
[x] updated urls.py file
[x] updated views.py file

Thing to be noted

Nothing was mentioned about read_blog.html file so I did not add it to the navbar

Running the manage.py file using 'python manage.py runserver' command will show the upgradations that I have done to the code. Waiting for the review. Thank you.

kavya1526 commented 3 years ago

@Anik-Bardhan The well structured form of your PR is appreciated. The functionalities also work fine and look good to me. But the branch has conflicts to be resolved. Please look into it so that we can merge your PR.

Anik-Bardhan commented 3 years ago

I can look into the conflicts but I do not have write access to that branch.

dishantvyas15 commented 3 years ago

I can look into the conflicts but I do not have write access to that branch.

@Anik-Bardhan, by resolving conflicts, I mean updating your forked repo. You'll need to pull and merge. This should do the needful.

kavya1526 commented 3 years ago

@Anik-Bardhan You are requested to solve the conflicts as soon as possible so that the work which follows it can be done.

Anik-Bardhan commented 3 years ago

I am facing issues with resolving the conflicts as I am new to github. I have already run the commands mentioned in the above screenshots, but the issues are not getting resolved.

kavya1526 commented 3 years ago

@Anik-Bardhan there is nothing that can be from our side for the same. Hence, we are closing the PR. The commits look correct, so to assure that your hardwork does not go in vain , we are putting the hacktoberfest-accepted label on your PR.