MSTC-DA-IICT / Hacktoberfest24-Quotes-App-Android

This repository is made for the purpose of Hacktoberfest-2024 to promote open source contributions
0 stars 5 forks source link

Design a QuoteDetailView #4

Closed parjanya-rajput closed 1 month ago

parjanya-rajput commented 2 months ago

Design a Card View which will show the Quote in more beautiful and highlighted way and the author name below it.

indra057 commented 1 month ago

1.can u assign me this issue... 2.should i create a specific card view where the quotes when clicked(from the lazy column list) show only the clicked quote along with the author in more beautiful and highlighted way if yes then i can proceed otherwise can u please describe in more specific way

parjanya-rajput commented 1 month ago

I am assigning you this issue once you do this I will assign another on which you've commented! should i create a specific card view where the quotes when clicked(from the lazy column list) show only the clicked quote along with the author in more beautiful and highlighted way if yes then i can proceed otherwise can u please describe in more specific way - Yes similar to this but as of now you just have to implement the design part click function is not required so just create a cardview once the Quotes are displayed then new issue will be raised for the same

indra057 commented 1 month ago

@parjanya-rajput sir i have created a QuoteDetailScreen that will take some input string of quote and input string of author (or from the lazycolumn or the viewmodel) and then display in a card ....is it okk or should i implement or change something else before give pull request as this part comes under design .. Screenshot 2024-10-05 185752

parjanya-rajput commented 1 month ago

For now just a keep a simple static string no need to take input or create viewModel. Design looks neat! Good job

indra057 commented 1 month ago

@parjanya-rajput sir can i submit a pr regarding this with input of quote as a static string and input of output as another static string

parjanya-rajput commented 1 month ago

Yes