MSTC-DA-IICT / REST-API-Node

Node JS project for Hacktoberfest 2021. Maintained by MSTC.
MIT License
2 stars 20 forks source link

Form to add a comment #35

Open YashTrivedi21 opened 2 years ago

YashTrivedi21 commented 2 years ago
Yash-271120 commented 2 years ago

@YashTrivedi21 Hi! can I work on this issue?

YashTrivedi21 commented 2 years ago

Sure!

Yash-271120 commented 2 years ago

@YashTrivedi21 So from what I unterstood I have to add a new input field for comment right? oie_kCOq9kR06XRc The input field should be after quantity?

YashTrivedi21 commented 2 years ago

Why do you need quantity to add to a comment? Also no need for customer name as customer id is foreign key so customer name can be used from that as well.

Yash-271120 commented 2 years ago

I am actually finding it difficult for me, may be someone else will take up the issue :)

YashTrivedi21 commented 2 years ago

Okay. no problem

Abhisekprabhakar commented 2 years ago

Hi ! i was looking into this issue image I got this at order page you want us to add comment right next to quantity or add another page form this ?

YashTrivedi21 commented 2 years ago

This was for placing an order. Now adding an comment is very similar to other social media platform. You view an order then below that you have a textbox or a button to add a comment. Once you press that button it takes you to another page where you can add your comments and after adding it the page will redirect right to that order showing the comment you added below the details of the order. I hope this is clear

Abhisekprabhakar commented 2 years ago

I think ,there is no scope in current code base where we can see orders to select and comment on . If there is any you let me know

YashTrivedi21 commented 2 years ago

Well if that's the case you can make a PR solving the issue and I will merge it. Once it's done I can assign you this issue as well. Also I will add hactoberfest-accepted tag to PR so no worries.

Abhisekprabhakar commented 2 years ago

okkk i am trying to add this somewhere !

YashTrivedi21 commented 2 years ago

Cool! What I would suggest is that just make a page in views folder. It can be an EJS page which will render the fields sent from backend. Add something like res.render("index", {desc: desc, quantity: quantity}) in backend. This is just an idea.

YashTrivedi21 commented 2 years ago

Are you done with this part @Abhisekprabhakar ?

harshmetkel24 commented 2 years ago

Hello, I was looking into this issue and found that no work has been done from more than a week. If @Abhisekprabhakar you are not working on the issue, then please reply. I would like to work on this.

Abhisekprabhakar commented 2 years ago

Hi, @harshmetkel24 you can take it from here i have made the pull request you can add (add comment) feature in orderView page if pull request gets approved

harshmetkel24 commented 2 years ago

Orders-view page PR is merged. So @YashTrivedi21, can you please assign this issue to me. I want to work on this.

YashTrivedi21 commented 2 years ago

Sure!

YashTrivedi21 commented 2 years ago

@harshmetkel24 any updates?

harshmetkel24 commented 2 years ago

@harshmetkel24 any updates?

First of all, sorry for being late in responding. I was a bit busy, for the last three days so. I worked earlier and found that the OrdersView page is not opening on any route as mentioned in Order.js. So now my doubt is if there are some bugs in that, can I add comments Form to the same page where a user is posting a new order, or should I tackle the OrdersView page first?

YashTrivedi21 commented 2 years ago

Tackle the bugs first, if not possible then you can work on the other option.

harshmetkel24 commented 2 years ago

Tackle the bugs first, if not possible, then you can work on the other option.

Yeah, I will see through it by tonight. And respond to you about the updates.

YashTrivedi21 commented 2 years ago

Any updates @harshmetkel24 only two days are left.