Auth for creating a comment - Githubissues

MSTC-DA-IICT / REST-API-Node

Node JS project for Hacktoberfest 2021. Maintained by MSTC.

MIT License

2 stars 20 forks source link

Auth for creating a comment #41

Open YashTrivedi21 opened 3 years ago

YashTrivedi21 commented 3 years ago

Check if user is already signed-in before creating a comment
Whenever user presses the create comment button on an order's page, user should be able to view create comment page with the form if user has logged-in else redirect to register/sign-in page
Use passport.js or any 3rd party library according to your choice.

hlavu commented 3 years ago

Hi @YashTrivedi21, I would like to work on this task. Please assign it to me. Thank you!

hlavu commented 3 years ago

Hi @YashTrivedi21, I just started working on this issue and I realized that this issue could be tackled only when the #issue35 is solved. Can I move to another issue such as adding a new page which is used to display food's pictures when user clicks on the item in the Menu section. If you agree, I will file new issue and work on it.

YashTrivedi21 commented 3 years ago

Ok no problem.

YashTrivedi21 commented 2 years ago

Any updates @hlavu ?

hlavu commented 2 years ago

@YashTrivedi21 Sorry for the late update, this week I was a bit busy. I will submit a PR next week.

YashTrivedi21 commented 2 years ago

@hlavu any updates?

hlavu commented 2 years ago

Hi @YashTrivedi21, I just started working on this issue and I realized that this issue could be tackled only when the #issue35 is solved. Can I move to another issue such as adding a new page which is used to display food's pictures when user clicks on the item in the Menu section. If you agree, I will file new issue and work on it.

I think the issue #35 has not been solved yet and also I had moved to work on the "create menu page". You can assign this issue for others. Thank you.

YashTrivedi21 commented 2 years ago

Alright no problem

AmasiaNalbandian commented 2 years ago

@YashTrivedi21 Hey I can try to make this happen, and can you let me know if the form for the comment is being completed or not? I can probably do both....

You just want a form for comments, and then use passport to make sure they're signed in? I haven't looked at all the code yet. I would like to know if there is already a session storage for being logged in user that I can just check then - that part is dealt with already correct?

YashTrivedi21 commented 2 years ago

I don't think session storage is implemented. You are right about the passport thing. If you can do both in a day then I can assign you both the task as I ain't getting any replies anywhere LoL.

YashTrivedi21 commented 2 years ago

I don't think form is completed, if you want I can assign that issue to you as well!

AmasiaNalbandian commented 2 years ago

@YashTrivedi21 Where is the DB information? The DB keeps failing to connect and the string honestly does not look correct.

YashTrivedi21 commented 2 years ago

App.js line 9. Standard way of connecting db to localhost with mongoose. If it doesn't work make a temporary db by yourself using gui or cli.

AmasiaNalbandian commented 2 years ago

@YashTrivedi21 Hey if you want to continue working on this repository for future, there are many missing implementations before the comment should be added. As of now there's no method to view an order, and there's no database information for this. Users should have orders saved through a POST method, and then we can fetch them and display all orders on a page. From there users should be able to select to view ONE order, and add comment.