Implemented footer - Githubissues

MSTC-DA-IICT / REST-API-Node

Node JS project for Hacktoberfest 2021. Maintained by MSTC.

MIT License

2 stars 20 forks source link

Implemented footer #48

Closed Ardent10 closed 2 years ago

Ardent10 commented 2 years ago

Below are my implementations. Here is a description of what I did: -Improved the code -Refactored it -Implemented footers on various pages -more responsive -all anchors are working and their redirects

bugs I found; -Bootstrap older versions is used which may or may not be deprecated -navbar is implemented from the older version of the bootstrap.

YashTrivedi21 commented 2 years ago

There are some merge conflicts currently. Please try to solve it, then if you face any problem notify me.

Ardent10 commented 2 years ago

app.js conflict: spaces nothing else which I made it as before
views/partials/header.ejs: The only change I did was just to put the navbar into the body of the header file, the navbar is not supposed to be in the head to the html. If we remain the navbar into the body, would that be an issue?

YashTrivedi21 commented 2 years ago

Shouldn't be an issue. But still if it creates conflicts then we can't help.

Ardent10 commented 2 years ago

It's done, check it out.

Ardent10 commented 2 years ago

Hey I wanted to ask one more thing, Can I make the navbar much better than what it currently is example like this.

Improving the anchors: They are currently unstructured.
make the page more responsive.

I am familiar with the project so I can do better

YashTrivedi21 commented 2 years ago

Sure! Then make a PR I will merge it with the tag!

Ardent10 commented 2 years ago