coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 84
- 37 of 108 (34.26%) changed or added relevant lines in 3 files are covered.
- 3 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+22.5%) to 52.656%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/main/java/edu/msudenver/cs/jdnss/Parser.java | 0 | 2 | 0.0% | ||
| src/main/java/edu/msudenver/cs/jdnss/RR.java | 32 | 66 | 48.48% | ||
| src/main/java/edu/msudenver/cs/jdnss/Response.java | 5 | 40 | 12.5% | ||
| <!-- | Total: | 37 | 108 | 34.26% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/main/java/edu/msudenver/cs/jdnss/Response.java | 1 | 44.78% | ||
| src/main/java/edu/msudenver/cs/jdnss/RR.java | 2 | 46.47% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 79: | 22.5% |
| Covered Lines: | 1031 |
| Relevant Lines: | 1958 |
wwhitecar
I think nsec.getBytes is returning the correct information when called. Also some minor changes to other RR records. Some other minor changes here and there, but no big changes outside nsec.getbytes.