search

MSaito / MTToolBox

C++ library to make GF(2) linear pseudo-random number generators
Other
37 stars 5 forks source link

Support MTL compiled with pthread, clean up compilation scripts #4

Closed grafi-tt closed 7 years ago

grafi-tt commented 7 years ago

Hi, Saito-san.

I'm planning to adding MTdc and MT-jump functionalities to numpy, but experienced errors when executing configure script.

One problem is: if MTL library is compiled with multi-threading support, you need to add -lpthreads when linking to MTL. I modified configure.ac to check this. The other is the lack of config.sub and config.guess. Running automake --add-missing -c copies these files.

I also noticed there are some redundant auto-generated files and not updated .gitignore, so cleaned up them. For such size of project, I personally prefer to putting .gitignore on subdirectories (see http://qiita.com/anqooqie/items/110957797b3d5280c44f [Japanese] for details), but I didn't changed it as it's just a matter of taste.

MSaito commented 7 years ago

Thank you for your patch. merged.

MSaito commented 7 years ago

In Mac OS, clang shows warning: clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Do you have any idea?

MSaito commented 7 years ago

I added AX_PTHREAD to configure.ac Everything seems to be OK.

grafi-tt commented 7 years ago

Thanks a lot. Excuse me for bothering you.