MSandro / sky_fabrication3

Fabric Skyblock Modpack (3rd generation)
3 stars 3 forks source link

Proposed changes for Sky FABRICation 3 #75

Closed KonSola5 closed 1 year ago

KonSola5 commented 1 year ago

Proposed changes for Sky FABRICation 3

For developers/debugging:

Not fixed:

MSandro commented 1 year ago

wow Thank you very much for your work.

MSandro commented 1 year ago

@KonSola5 whats your Curseforge name? I would like to add you as an developer on the Modpack Page.

KonSola5 commented 1 year ago

konsola5

MSandro commented 1 year ago

Thanks for your contribution, it's a big help. I currently have hardly any time to take care of the project, which I think is a pity myself. I will take a closer look at your changes in the next few days and then probably merge and release them as an update in the next 2 weeks.

KonSola5 commented 1 year ago

One thing to note about the quests: There is a missing item in the center checkmark of "Building" tab section (it's set to staffofbuilding:infinite_builder_staff, but there's no "Staff of Building" mod in this modpack). It should be changed or removed altogether.

MSandro commented 1 year ago

One thing to note about the quests: There is a missing item in the center checkmark of "Building" tab section (it's set to staffofbuilding:infinite_builder_staff, but there's no "Staff of Building" mod in this modpack). It should be changed or removed altogether.

weird, thanks I will change it.

KonSola5 commented 1 year ago

Noticed that a new branch has been created, switched PR to that new branch.

MSandro commented 1 year ago

Noticed that a new branch has been created, switched PR to that new branch.

Yes, I am working on v0.6.0 and I am merging your changes their.

KonSola5 commented 1 year ago

A prototype of a new addition: Custom TiC tools made out of Twilight Forest materials! steeleaf

Here's Steeleaf, makes decently fast and sharp tools, has low durability, but can resist 75% durability damage when the player is in sunlight. (Balanced around actual Steeleaf Tools).

fiery

Fiery - makes good tools and weapons, has medium durability, and sets things on fire. Again, balanced around actual Fiery tools.

KonSola5 commented 1 year ago

Also coming: A Step-Up modifier fix, using emi's step_up attribute, that's used by ex. Spectrum. stepup

MSandro commented 1 year ago

Thanks for your awesome help @KonSola5 Sorry, I didn't want to finally merge the pull request, I made a mistake operating the Git command. I hope that doesn't cause you any problems. I have a request, Could you have a look why the gold drill has no outputs when you have activated the expert mode? Maybe you have an idea what it is, I didn't remove it explicitly.

/kubejs custom_command expert
KonSola5 commented 1 year ago

I didn't activate the new Expert Mode yet, the comments about the recipes were made from reading the changed .json's themselves. But I will investigate this when I will be having free time.