search

MSandro / sky_fabrication3

Fabric Skyblock Modpack (3rd generation)
3 stars 3 forks source link

Extra changes for Sky FABRICation 3 #78

Closed KonSola5 closed 1 year ago

KonSola5 commented 1 year ago

A new PR, since MSandro made an whoopsie. But this will also enable easier sync with MSandro's changes, so win/win.

KonSola5 commented 1 year ago

Due to a Botania chapter redesign, the descriptions are lost. That's a great redesign by the way! 👍 But that also means rewriting quest descriptions again. Yay.

MSandro commented 1 year ago

I will add the Descriptions for the Botania and Bewitchment chapters in my next commit. Thank you for your work on the IndRev chapter.

KonSola5 commented 1 year ago

Also up coming: Retexture of TiC Tools to better match ingots they come from.

pickaxes

KonSola5 commented 1 year ago

The new TiC Materials: tic

Knightmetal actually has Piercing II (is it too powerful or not?)

Knightmetal and Neutronium can also be used to embellish armor! Embellishing Plate Armor with Neutronium yields a wannabe Infinity Armor (decorative only, no special abilities).

Neutronium Embelished Armor

The only things that are missing: Repair materials for Knightmetal and Fiery tools.

MSandro commented 1 year ago

The new TiC Materials: Knightmetal actually has Piercing II (is it too powerful or not?)

Great idea, i think its fine 👍

KonSola5 commented 1 year ago

Also changed the Relic Quests, so they don't have NBT data of the owner. (You probably added the relic quests from items in inventory, that's why they had your UUID.)

MSandro commented 1 year ago

Thank you so much for your help. I will try to release v0.6.0 in the next few days.

KonSola5 commented 1 year ago

One more thing to state: In Create Chapter in the Windmill quest, I stated about 256 sail-like blocks to max out. But it's actually 128 of those.

You can't add repair materials to tools made only out of molten metal. (Could be possible in a very hacky way to add a modifier that allows a tool to be repaired using fiery/knightmetal). Repair kits still work though.

MSandro commented 1 year ago

image thans, I have edited the description.

In case of TConstruct improvements, I think this can be done in future updates.

KonSola5 commented 1 year ago

A bug that I found: When creating a new world, after the pack-mode selection screen, no Origin selection screen nor inventory unlock is shown to a player.

Edit: Submiting the very first quests brought up the aforementioned things. Maybe tell the player that they need to open their quest book first?

MSandro commented 1 year ago

Thanks I will try to reproduce it.