Container cost and size configurability

[nbusseneau]

Hey, thanks for your mods and Jotunn 😄

What do you think about adding configurability for the container sizes and initial cost? I don't think allowing to configure each stack individually is needed, but just setting the shared cost/size of all containers.

Use case: skimming through the description I actually expected the stacks would not allow for storing more than vanilla (e.g. 1 full wood stack = 50 wood). If the container size was configurable, I would personally set it to just 1 slot so as to get to that, instead of allowing to store so many resources in one stack 😅

And with only one slot, allowing to create a stack with a cost of just 1 instead of 10 would make it less restricting.

[MSchmoecker]

Thanks!

First of all, let me explain the reasoning behind the choice. The stacks have the same inventory space and cost the same amount of items as a wooden chest. However, they usually take up more build space and only accept one item type. So I think it's a fair trade.

That being said, you can use mods like AzuContainerSizes to change the inventory sizes and WackysDatabase to change the piece cost. There will be no configs for the time being, as the added complexity doesn't seem to be justified when the other mods already do the job very well.

The prefab names can be found here (or use a mod like VNEI or AzuHoverStats) https://github.com/MSchmoecker/Dynamic-Storage-Piles/blob/e1fe35f93d7c2dcb0da7e24d0f1cc016f9707b23/DynamicStoragePiles/DynamicStoragePiles.cs#L52-L63

[nbusseneau]

Thanks, yeah I know about those but believe it's better when the mod does it directly (especially because of how WackyDB cloning behaves) 😅

Is this a soft or hard stance (i.e. you would not do it yourself but would you accept or refuse a pull request adding this)?

[MSchmoecker]

If a PR adds this feature, works good and isn't too complex, it will very likely be merged.

This implies the crafting cost is synced with Jotunn's ConfigSync and all edge cases regarding inventory size changes are handled properly. E.g when the size is set smaller and items are still inside the pile

[nbusseneau]

Aye, maybe I will try something at some point then.

[nbusseneau]

FYI, in the end I do not intend to try and submit a PR:

• After thinking about it some more, your rationale makes sense. Considering the vanilla chest cost and container size, it indeed is necessary to have something in line with this for Dynamic Storage Piles to have a sensible use case in game.
• After testing as part of our modpack, we ultimately decided to go with https://thunderstore.io/c/valheim/p/Balrond/balrond_containers/ (mostly because it fit the camp vibe we wanted to go for better, e.g. with the generic wood shed allowing to stockpile multiple types of wood).

So instead I am currently making changes to Balrond Containers to have it work in a way similar to Dynamic Storage Piles (notably adding in restrictions on allowed items, because by default there is none).

I suppose we can close this issue, unless you want to leave it up open for someone else to maybe grab in the future 😄