Closed jonathan-annett closed 1 year ago
jonathan-annett
commented
1 year ago I decided to leave the compile.bat as is, and created a build.bat instead which implements the "build for this pc" logic
i've also added a package.json file the repo can be included as a sub package - i'm creating a nodejs/electrol/nwjs module that implements desktop switching on windows.
commit 6e6f2c806fed397cc474e90aa99ca4854a14aece has all these changes)
jonathan-annett
commented
1 year ago added an interactive mode (will mainly be used by node.js wrapper, to stay running, report changes, and respond to commands via stdin (uses same format as command line, with a few commands omitted)
MScholtes
commented
1 year ago Hello @jonathan-annett,
I will not merge your pull request because
Greetings
Markus
jonathan-annett
commented
1 year ago All good. I'll keep your credit in my repo and link back to it
(There is a use BTW. Google bitfocus companion)
On Tue, 31 Oct 2023, 2:40 am MScholtes, @.***> wrote:
Hello @jonathan-annett https://github.com/jonathan-annett,
I will not merge your pull request because
- I do not see any use in a Javascript integration of VirtualDesktop
- see my contribution guide
Greetings
Markus
— Reply to this email directly, view it on GitHub https://github.com/MScholtes/VirtualDesktop/pull/74#issuecomment-1785490108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGSBMENA7CAAUF6QHHR773YB7C6DAVCNFSM6AAAAAA6KS6ALSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGQ4TAMJQHA . You are receiving this because you were mentioned.Message ID: @.***>
jonathan-annett
commented
1 year ago Fyi
https://github.com/bitfocus/companion/wiki/Module-Development
https://github.com/jonathan-annett/virtual-desktop-node
https://github.com/jonathan-annett/companion-module-sophtwhere-virtual-desktop
On Tue, 31 Oct 2023, 2:40 am MScholtes, @.***> wrote:
Closed #74 https://github.com/MScholtes/VirtualDesktop/pull/74.
— Reply to this email directly, view it on GitHub https://github.com/MScholtes/VirtualDesktop/pull/74#event-10809696724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGSBMBTSDDIQXHG5ACX7S3YB7C6DAVCNFSM6AAAAAA6KS6ALSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHAYDSNRZGY3TENA . You are receiving this because you were mentioned.Message ID: @.***>
waits until the current desktop has changed before next continuing
(also changes the compile.bat strategy to build/test each version until a working candidate is found, always produces output as VirtualDeskop.exe regardless of what version is used)