TASK 2 - Githubissues

MScientistCM / March2019ToV6Conversion

I created this repo to convert March2019 database to be compatible with saturn v6 patch. Once completed, I will probably delete this project from github.

0 stars 1 forks source link

TASK 2 #2

Closed MScientistCM closed 5 years ago

MScientistCM commented 5 years ago

d. Rename Holland --> Netherlands in euro.cfg. [Notepad] e. Rename Holland --> Netherlands (four times) in nat_club.dat. [XVI32] f. Rename Holland --> Netherlands (twice) in nation.dat. [XVI32]

MScientistCM commented 5 years ago

Task done and pushed.

MScientistCM commented 5 years ago

Oh no, I just realized the XVI32 tool 'find and replace' doesn't preserve the ammount of zeroed bytes after replacing an string. This means the zeroes need to be added/removed manually after replacing an string... So im reopening this ticket to add/remove the zeroes.

MScientistCM commented 5 years ago

done (correctly now, preserving number of bytes of the fields) and pushed.

Dermotron commented 5 years ago

I am wondering if this is the cause of the issues with the international managers? When added back from the Master to the active version, all the managers are the at the wrong Nation -1 e.g. Christian Panucci is the manager of Albania in real life but in the DB he is manager of Afghanistan. Even if I put the staff.dat from the March 2019 Data Update (unpatched) it's the same scenario

What I mean is, does the international manager of the Netherlands needs to be edited at this stage to prevent the " - 1 " scenario

MScientistCM commented 5 years ago

I will double check, but Im pretty sure the issue isn't occurring anymore since the last database you sent me yesterday night. I still didnt update the link in the beta thread though so you may be testing with the previous database?

Dermotron commented 5 years ago

Sorry, I posted here before seeing your post on the forum

MScientistCM commented 5 years ago

reuploading from sendspace the database version with all issues fixed: Data.zip I'll update the links in the beta thread. Thanks @Dermotron

MScientistCM commented 5 years ago

Link for download the final beta version of the converted database, which should be the base for saturn create the v7 patch:

DataFinalBetaV6March2019.zip

The changes since the previous beta version are:

Fix by Andrea for the itally positions.
Fixed two MLS team lines in player_setup.cfg that got overwritten by some other changes.
Added default eidos.rgn file as saturn did for v6 data.
Added game.mbr and match.mbr file as saturn did for v6 data.
Added the change from 11 to 12 in jap league rep in club_comp.dat which I thought I had added but I actually forgot :)

I reviewed all conversion steps from 1 to 9 and it contains all of them correctly. I also tested and is stable and working as expected. This database doesn't need any modifications and can be released as is for v7, unless saturn wants to change something in the database, or if some of the patches he will do will require to change the database.