search

MScientistCM / March2019ToV6Conversion

I created this repo to convert March2019 database to be compatible with saturn v6 patch. Once completed, I will probably delete this project from github.
0 stars 1 forks source link

TASK 4 #4

Closed MScientistCM closed 5 years ago

MScientistCM commented 5 years ago

i1. Delete any lines beginning with "RETIREMENT" if you want to prevent those players from immediately retiring once the game starts. [Notepad] i2. Convert future transfers into loans: add the loan lines into player_setup.cfg [Notepad] and move the players between clubs. [Tri Wasano Editor]

MScientistCM commented 5 years ago

Dermotron: I disagree with cancelled future transfers though MadScientist: Yeah that step looks weird. Perhaps its a required step to be compatible with v6 patch due to some limitation of v6 though. I guess we will find out Dermotron: I think he didn't/doesn't agree with the reasoning for some of the future transfers e.g. loans with a fee. Future Transfers from the Reserve sides to main sides can't be loans for instance

Dermotron commented 5 years ago

I'll edit the player_setup.cfg to auto bring everything forward 17 years. I'm unsure if the patch automatically does this.

Dermotron commented 5 years ago

Manually increased by 17 years

player_setup.zip

jacobclear commented 5 years ago

@Dermotron I'm assuming this one is done mate?

MScientistCM commented 5 years ago

I'll edit the player_setup.cfg to auto bring everything forward 17 years. I'm unsure if the patch automatically does this.

I replaced the original player_setup.cfg with your file @Dermotron and pushed it in commit c53c0a2, because I agree the patch probably wouldn't bring it forward everything 17 years automatically. However its weird saturn didn't mention this step.

Anyway, later when its all completed we will test and know. If we notice the patch auto forwards, then I'll revert the commit, but that would require re-doing ticket #3 because it also touches the same file and the revert would conflict.

MScientistCM commented 5 years ago

Actually, now I've looked in the player_setup.cfg file from the Data folder that saturn uploaded for his v6 patch and I see all dates are 2001...2002, so it means the patch really forwards everything automatically 17 years. So I reverted commit c53c0a2 now because its not needed. Ticket #3 can be done normally as well.

MScientistCM commented 5 years ago

The following are the lines beginning with "RETIREMENT":

    Line 4381: "RETIREMENT" "Deniz" "" "Dogan" "Eintracht Braunschweig II" 15 6 2002 
Line 4398: "RETIREMENT" "Michael" "" "Carrick" "Manchester United" 15 6 2002 
Line 4409: "RETIREMENT" "Per" "" "Mertesacker" "Arsenal" 15 6 2002 
Line 5095: "RETIREMENT" "Arnold" "" "Kruiswijk" "Vitesse Arnhem" 15 6 2002 
Line 5518: "RETIREMENT" "Michael" "" "Essien" "FK Sabail" 1 8 2001 
Line 5818: "RETIREMENT" "Roman" "" "Weidenfeller" "" 15 6 2002 
Line 6392: "RETIREMENT" "Anders" "" "Egholm" "" 1 6 2001 
Line 6417: "RETIREMENT" "Shane" "" "Stefanutto" "Olympic FC Brisbane" 1 5 2001 
Line 6504: "RETIREMENT" "Stefan" "" "Kießling" "Bayer 04 Leverkusen" 1 7 2002 
Line 6516: "RETIREMENT" "Viktor" "" "Faizulin" "" 15 6 2002 
Line 6521: "RETIREMENT" "Yann" "" "Kermorgant" "" 15 6 2002 
Line 6920: "RETIREMENT" "David" "David Villa" "Villa" "Vissel Kobe" 31 12 2003 
Line 9037: "RETIREMENT" "Dario" "" "Vujicevic" "FC Eintracht Rheine" 1 6 2001 
Line 9103: "RETIREMENT" "Kasper" "" "Risgaard" "Aalborg BK" 15 6 2002 
Line 10151: "RETIREMENT" "Petr" "" "Cech" "Arsenal" 2 7 2001

@Dermotron Which of the players above do you prefer I prevent from retiring immediatelly once the game starts? All of them, or do you prefer I prevent only some of them?

Dermotron commented 5 years ago

All of them should be the end of season 1, not instantly - Petr Cech being the most obvious and biggest mistake. Any that start pre 1 7 2001 won't work anyhow.

MScientistCM commented 5 years ago

done and pushed. Deleted the lines with RETIREMENT because saturn explained once that there is a limitation in his patch in which setting a future retirement causes the player to instantly retire and the only work-around is to delete the future retirement lines.

Note: As discussed, I didn't do this step: "i2. Convert future transfers into loans: add the loan lines into player_setup.cfg [Notepad] and move the players between clubs. [Tri Wasano Editor]"

Dermotron commented 5 years ago

I'm try adding them to the current v6 player_setup.cfg with 2019 as end dates to see if it works. Most are old so it's no big deal

MScientistCM commented 5 years ago

yes nice idea worth trying

jacobclear commented 5 years ago

Programming 101 - getting the damn thing to work

Nice thinking MS

Dermotron commented 5 years ago

Indeed Retirement does not work. It's instant even forward dated manually

Dermotron commented 5 years ago

I understand saturn's logic for this now - it was because players on loan can't be sign so in a lot of cases the point of the future transfer is irrelevant e.g. James is at Bayern due to his real life loan being a paid loan

Not all future transfers in the game are loans so it would require a lot of research to figure out which it has been done for and which are genuine e.g. Frenkie de Jong to Barcelona from Ajax is a legitimate future transfer