search

MShekow / renovate-pr-visualization

MIT License
6 stars 2 forks source link

Fix GitLab group support and pagination #11

Closed MShekow closed 1 month ago

MShekow commented 2 months ago

Fixes #8 and #10

@szpak please try it out and provide feedback, if possible

szpak commented 2 months ago

I've just run it and it worked, thanks!

All direct repos and from the subgroups were discovered when a group/subgroup pattern was provided in REPOS. It took some time to fetch the PRs (and even more for get the onboarding statuses - even up to 10 second per repo), but it was still <1 minute for ~15 repos and ~150 MRs.

The scrapper hit a few times "Unable to parse dependency table: expected Link, but got", but it is not related and I will examine that and I will report it separately with sample MRs.

It would be probably good to have @robrobert99 run it with his repos, but for me it looks ok :) (btw, I haven't tested the user: case)

MShekow commented 2 months ago

Thank you. There were a few more problems with user: repos, which I fixed.

robrobert99 commented 1 month ago

It worked for me with my repositories as well, but it also worked with the first implementation of the GitLab client. I noticed no difference in performance and had no error logs. However, I had one warning for gitlab_client.py at line 71, where the get_all=True parameter could be set as well.

MShekow commented 1 month ago

It worked for me with my repositories as well, but it also worked with the first implementation of the GitLab client. I noticed no difference in performance and had no error logs. However, I had one warning for gitlab_client.py at line 71, where the get_all=True parameter could be set as well.

Hey, thanks for your feedback. However, I'm confused about line "71" in gitlab_client.py, this line calls one of my own functions, so something is off. Could you check again which specific call is affected?