search

MShekow / renovate-pr-visualization

MIT License
6 stars 2 forks source link

GitLab support #3

Closed szpak closed 2 months ago

szpak commented 8 months ago

It would be good to support also GitLab as a Git repository.

MShekow commented 8 months ago

Agreed. I have my hands full these days with other projects, but I'm planning to add GitLab support in January. Unless you or someone else wants to contribute it.

szpak commented 8 months ago

I took a look at the code and GitHub part seems to be highly coupled with the rest. Probably bigger some refactoring with extracting the Git-provider related code is needed. It's your code, you know it very well and in my option you are the best person to do it properly.

Impatiently waiting for January :)

MShekow commented 8 months ago

Jup, the coupling is making it more difficult to extend the code. I'm indeed planning to add an abstraction layer.

MShekow commented 8 months ago

By the way, in case you have some free time and interest, you could research which SDK calls (using this Gitlab SDK) are equivalent to the githubkit SDK calls I'm making in the code. That would take a lot of work off my plate.

HonkingGoose commented 8 months ago

Looks like you switched from githubkit to PyGitHub recently:

So is this still relevant?

By the way, in case you have some free time and interest, you could research which SDK calls (using this Gitlab SDK) are equivalent to the githubkit SDK calls I'm making in the code. That would take a lot of work off my plate.

MShekow commented 8 months ago

Yes, still relevant. The wording is now:

in case you have some free time and interest, you could research which SDK calls (using this Gitlab SDK) are equivalent to the PyGithub SDK calls I'm making in the code. That would take a lot of work off my plate.