Fantastic work! Can you make the application a multilingual version?

MSzturc / ThinkpadAssistant

An Assistant Application that allows you to use all your Function Keys on a T-Series Thinkpad Laptop

124 stars 13 forks source link

Fantastic work! Can you make the application a multilingual version? #1

Closed hexart closed 4 years ago

hexart commented 4 years ago

I'd very much like to provide a Chinese language pack.

MSzturc commented 4 years ago

Great Idea! Do i have to create language profiles for all three Chinese languages?

hexart commented 4 years ago

ThinkpadAssistant-1.2.0.zip

Here‘s the simplified Chinese language pack, its working.

hexart commented 4 years ago

I'll draw a vector menu icon later, wish it could surprise you.

hexart commented 4 years ago

I found a issue, microphone mute function works, but the light on F4 key isn't on, does this happen to you?

MSzturc commented 4 years ago

Wow... :-) Until now i didn't noticed that there is a light on F4 key, thats cool. Now i have to find out how to activate it

hexart commented 4 years ago

How does it look? If you like it, tell me which format and what size do you need for the menu icon.

MSzturc commented 4 years ago

Ohhh wow the icons are awesome. I need them in png format at follow sizes (for light and dark theme )

Icon size (@1x)	Icon size (@2x)
512px × 512px (512pt × 512pt @1x)	1024px × 1024px (512pt × 512pt @2x)
256px × 256px (256pt × 256pt @1x)	512px × 512px (256pt × 256pt @2x)
128px × 128px (128pt × 128pt @1x)	256px × 256px (128pt × 128pt @2x)
32px × 32px (32pt × 32pt @1x)	64px × 64px (32pt × 32pt @2x)
16px × 16px (16pt × 16pt @1x)	32px × 32px (16pt × 16pt @2x)

Taken form the apple style guide from here:

https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/

MSzturc commented 4 years ago

I've figured out how to set and reset the F4 LED. Currently i implemented an toggle which is kind of messy since its not syncronized with muting functionality. I guess i have to write ein kext to communicate with the led from Userland

Ive commited my changes to my T460 build here

hexart commented 4 years ago

I've figured out how to set and reset the F4 LED. Currently i implemented an toggle which is kind of messy since its not syncronized with muting functionality. I guess i have to write ein kext to communicate with the led from Userland

Ive commited my changes to my T460 build here

Super! I'll test it later.

hexart commented 4 years ago

MenuIcon.zip Here's the image resource with both rasterized png and vectorized pdf version. I wish it could look like this.

MSzturc commented 4 years ago

I've added the new icon for menuBar and appIcon. It's sad that apple doesn't support darkMode for appIcons so the white background icons are only used in menuBar. Big thx for the Icons.

hexart commented 4 years ago

Glad I can help. The current app icon is fine, maybe I will try to redesign it with more details like 3d and light effects in few days.

simprecicchiani commented 4 years ago

I added Italian language as suggested by @hexart. Does the icon look too big on your system too?

MSzturc commented 4 years ago

I added Italian language as suggested by @hexart. Does the icon look too big on your system too?

Thx for the translation. I've merged you PR and Released a new Version of ThinkpadAssistant. In this Version I reduced the Iconsize of the Menubar Icon a bit. Have fun testing

simprecicchiani commented 4 years ago

Thx for the translation. I've merged you PR and Released a new Version of ThinkpadAssistant. In this Version I reduced the Iconsize of the Menubar Icon a bit. Have fun testing

Translation works and icon looks way better now. Mic button (F4) is broke on 1.4 release, it doesn't perform any action.

Edit: I've just seen the new SSDT config, fixed it. Thanks again.

junaedahmed commented 3 years ago

Hello @hexart ,

I am asking for some graphics help from you. You before helped this project with some cool graphics. Could you please look at this YogaSMC project. And if you have spare time it would be great help if you could contribute some graphics there. It is a similar project like ThinkpadAssistant, but more general and covers a large Models.

Regards Junaed

hexart commented 3 years ago

Hello @hexart ,

I am asking for some graphics help from you. You before helped this project with some cool graphics. Could you please look at this YogaSMC project. And if you have spare time it would be great help if you could contribute some graphics there. It is a similar project like ThinkpadAssistant, but more general and covers a large Models.

Regards Junaed

Sure, I'll see what I can do.

junaedahmed commented 3 years ago

Sure, I'll see what I can do.

Thanks a lot for your help