New Icons for Keyboard Backlight

[MSzturc]

@hexart @EETagent @tylernguyen @Sniki To have a central space to discuss the keyboard backlight icon design with @hexart i've opened a new Issue, feel free to give him all the input you like, he will design the new hud.

[MSzturc]

Here is an overview of the current used icons:

[EETagent]

My personal favourite design is proposal from @Sniki

The design is in the spirit of Apple and is in line with the backlight control style on Windows

The turned off design will need to be reworked. Prohibitory sign looks like some error ... It might be good to use Apple's approach, but I think it's too empty.

[hexart]

I‘d prefer using Apple’s design language for this icon, how about its look?

[tylernguyen]

@hexart That looks pretty good! Is there a way to make dim and bright look a bit more different though? They look fairly similar.

[EETagent]

I‘d prefer using Apple’s design language for this icon, how about its look?

Good. Both proposals are great. Apple uses the line as an indicator of brightness though. Therefore, I prefer the proposal above

[hexart]

First of all, unlike apple’s native icon, the function in Thinkpad assistant isn’t with fine-tuning, I think that why @MSzturc add text label under it to make it looks more balanced. Secondly, the purpose of the HUD icon is to give us abstract symbolic visual feedback. As long as it gives us enough information about where we are, I think the simpler the better, and that’s exactly what we want. backlitoff.pdf backliton.pdf backlitdim.pdf

[tylernguyen]

@hexart I agree with you. And honestly I do not mind too much one way or another. The current icons have already satisfied me. You are doing a great job and it's up to you to decide in the end!

[Sniki]

Personally both my and @hexart draft are my two favorites and im perfectly fine on which one you guys pick.

I like the @hexart idea as well for doing the change on the HUD icon so it has shorter lines for (dim) and longer lines for (bright) instead of putting two bars on the bottom whether you want or don't want text.

So @hexart you have my +1 vote, thanks for the design.

[MSzturc]

@hexart I've tried your new icons in Thinkpad Assistant

It's a personal preference but don't you think that the free space between the icon and the text is too big?

[Sniki]

@hexart I've tried your new icons in Thinkpad Assistant

It's a personal preference but don't you think that the free space between the icon and the text is too big?

Yes, that's too small in my opinion, i would almost double the size of the icon there. Too much blank space

[hexart]

Yes it's too small, I'll download another icon in your source code as a reference.

[EETagent]

Since all the proposals are perfect and the community has agreed on a @hexart proposal, I am also in favour of it. Really great job, it never occurred to me that I could one day use functional ThinkPad keys even in macOS

[hexart]

backlitoff.pdf backliton.pdf backlitdim.pdf Try these again, please

[Sniki]

@MSzturc @hexart since we are touching the roof of perfection of the ThinkPad Keyboards: Do you guys think it would be great to also have a Caps Lock HUD since there is no light on the Caps Lock button it's hard to know if it's on or Off unless you text ?

[tylernguyen]

@Sniki

That sounds great! The thing though is the that some ThinkPads do the have the CapsLk LED, such as my x1c6. So that in adding support, there would need to be an option to turn off CapsLK HUD for machines who already have an LED and prefer not have an HUD.

In other cases, I could just not add the ACPI patch for CapsLK. But since CapsLk is handled via ADB, not EC. I cannot do so.

[hexart]

@MSzturc @hexart since we are touching the roof of perfection of the ThinkPad Keyboards: Do you guys think it would be great to also have a Caps Lock HUD since there is no light on the Caps Lock button it's hard to know if it's on or Off unless you text ?

Sorry, I don't think so. Imagine that you're typing an important manuscript, you need to switch Capslock on and off very frequently, the HUD will drive you crazy.

[Sniki]

@MSzturc @hexart since we are touching the roof of perfection of the ThinkPad Keyboards: Do you guys think it would be great to also have a Caps Lock HUD since there is no light on the Caps Lock button it's hard to know if it's on or Off unless you text ?

Sorry, I don't think so. Imagine that you're typing an important manuscript, you need to switch Capslock on and off very frequently, the HUD will drive you crazy.

Well i can agree on this and that can turn out to be a PITA.

[hexart]

@hexart I've tried your new icons in Thinkpad Assistant

It's a personal preference but don't you think that the free space between the icon and the text is too big?

This is the final effect I want, if its possible, can you draw the image layout on this image? if you do, I'll adjust the icon assets once and for all.

[private-static]

The Fn+Space keyboard backlight hotkey works normally in my T470s without ACPI patch, and I wonder if I need to apply your new _Q1F patch.

[Sniki]

The Fn+Space keyboard backlight hotkey works normally in my T470s without ACPI patch, and I wonder if I need to apply your new _Q1F patch.

It works for all of us but the point is that we patch it to generate a specifc code that can be mapped on ThinkPad Assistant so we can add the GUI, we also add some checks so if backlight is off, the next HUD is level 1 (dim) if it is dim the next gui is (Bright) etc / vice versa (you get the idea)

[private-static]

The Fn+Space keyboard backlight hotkey works normally in my T470s without ACPI patch, and I wonder if I need to apply your new _Q1F patch.

It works for all of us but the point is that we patch it to generate a specifc code that can be mapped on ThinkPad Assistant so we can add the GUI, we also add some checks so if backlight is off, the next HUD is level 1 (dim) if it is dim the next gui is (Bright) etc / vice versa (you get the idea)

Got it. Thank you very much.

[MSzturc]

@hexart I've tried your lastest icons in Thinkpad Assistant

Looks awesome!

[hexart]

Better move it down a little bit, I'll modify it later.

[hexart]

@hexart I've tried your lastest icons in Thinkpad Assistant Looks awesome!

Hi, I moved them down to 134px and make sure it's in the precise position. backlitdim.pdf backlitoff.pdf backliton.pdf

[hexart]

This is the Wi-Fi icon in apple's installer, what do you guys think?

[Sniki]

This is the Wi-Fi icon in apple's installer, what do you guys think?

Yes please !,

Let’s have an Apple standard across all icons

[MSzturc]

Here are the new Icons inside Thinkpad Assistant

[EETagent]

@MSzturc @hexart

Perfect

[MSzturc]

@hexart This should help you fitting the images to the HUD size in the future

[Sniki]

Here are the new Icons inside Thinkpad Assistant

This one looks perfect 👌

[Sniki]

@MSzturc i have a user that reported a small issue with the Microphone Mute LED after wake from sleep. If mic is muted and you put laptop to sleep, after you wake it, the mic will remain muted but the LED is turned of, is it possible to tweak the led code for such check as we did with Keyboard Backlight ? Quote:

The Thinkpad Assistant utility is great, I just found one issue and I am not sure it is an app bug or a problem with SSDT.

When I mute the microphone with fn+f4 the small led on f4 lights on, put the Thinkpad to sleep, wake it up again the small led on f4 is off but the microphone is still muted according to Thinkpad Assistant (pressing fn+f says it switched to unmuted).

[hexart]

@hexart This should help you fitting the images to the HUD size in the future

Got it! backlitdim.pdf backliton.pdf backlitoff.pdf

[Sniki]

@Sniki

It's a problem in ACPI. You have to restore LED State after wakeup. You have to patch _WAK and inside you have to restore LED state ( we created an Variable which should be still present after wakeup ). Have a look here for reference : https://github.com/zhtengw/EFI-for-X1C6-hackintosh/blob/e73ddb21e1192990e3e2156f3613b735bf71de75/ACPI/SSDT-SLPWAK-X1C6.dsl

Thanks for the clarification.

I did post an issue where i asked a few questions on your T460 repository, i would like to have a summary for those as well like you explained this one (when you have time for it).

https://github.com/MSzturc/Lenovo-T460-OpenCore/issues/3

Thanks for all.

[hexart]

@MSzturc @EETagent @tylernguyen @Sniki I made two wifi-off icons, will you guys help me to decide which is better?

wifioff.pdf wifioff1.pdf wifion.pdf

[MSzturc]

I like this combination:

[EETagent]

I did a flash editing in Preview. Ignore the stripe below icon :) And the blank version looks better

[Sniki]

@MSzturc @EETagent @tylernguyen @Sniki I made two wifi-off icons, will you guys help me to decide which is better?

wifioff.pdf wifioff1.pdf wifion.pdf

My choice is the same as @MSzturc The black one doesn’t look right, the blank one looks like native and resembles Apple guidelines.

[hexart]

My choice is the same as @MSzturc The black one doesn’t look right, the blank one looks like native and resembles Apple guidelines.

Same as you, let the author do the honor;)

[MSzturc]

I've added the new WiFi and the updated Backlight Icons into Thinkpad Assistant! Thx for the good work @hexart