[Feature request] Capslock indicator

MSzturc / ThinkpadAssistant

An Assistant Application that allows you to use all your Function Keys on a T-Series Thinkpad Laptop

118 stars 13 forks source link

[Feature request] Capslock indicator #28

Closed igorkulman closed 4 years ago

igorkulman commented 4 years ago

The T440s, and probably other models, does not have an Capclock indicator, could you add an icon for on/off same as with sound / microphone?

MSzturc commented 4 years ago

We discussed this feature a couple weeks ago and decided us against an implementation. The main reason was the fact that its pretty annoying when the hud pops up and blocks your screen when you are working on for example word or excel document where you use caps lock very often.

igorkulman commented 4 years ago

Would you accept a PR that adds with a menu item to enabled / disable it?

igorkulman commented 4 years ago

Something like

and

MSzturc commented 4 years ago

Sure, but I would suggest that you reduce the size of the arrow a bit. @hexart What do you think?

igorkulman commented 4 years ago

It is basically a random free icon from the Internet. Better icon would be needed.

hexart commented 4 years ago

Sure, but I would suggest that you reduce the size of the arrow a bit. @hexart What do you think?

Cool! I can't agree more since we provide a caps lock switch in app menu. I'll try to draw a pair of icons later in two days.

MSzturc commented 4 years ago

Thx for the pull request. As soon as we have an better icon I will merge it. TX for your contribution

hexart commented 4 years ago

I get it from iOS keyboard layout design.

igorkulman commented 4 years ago

I get it from iOS keyboard layout design.

I think it looks OK. If you upload it I will update my PR #30

hexart commented 4 years ago

capslockoff.pdf capslockon.pdf

Sorry for the delay, I've been so busy these days.

igorkulman commented 4 years ago

capslockoff.pdf capslockon.pdf

Sorry for the delay, I've been so busy these days.

Thanks. I updated the PR.