Use switch rather than nested ifs

MSzturc / ThinkpadAssistant

An Assistant Application that allows you to use all your Function Keys on a T-Series Thinkpad Laptop

118 stars 13 forks source link

Use switch rather than nested ifs #39

Closed 1Revenger1 closed 3 years ago

1Revenger1 commented 4 years ago

Reduces complexity for Mic and Keyboard backlight, and also makes it clearer. Also fixed the externals to allow the file to be compiled without it throwing errors about missing functions.

The X1C6 patches worked btw for my X1 Extreme. I don't know if you want to change anything in the README/Samples folder to reflect that.

tylernguyen commented 3 years ago

@1Revenger1

That sample is outdated. We added FnLock support a while back: https://github.com/tylernguyen/x1c6-hackintosh/blob/master/patches/SSDT-Keyboard.dsl

EDIT:

Also the patches were also meant to go with another LED patch that fixes the LED state after sleep: https://github.com/tylernguyen/x1c6-hackintosh/blob/master/patches/SSDT-LED.dsl

You may want to update to the two patches above since your PR renames a few things.

1Revenger1 commented 3 years ago

I don't see how SSDT-LED relates to this PR specifically, but I may include it for my X1 - thanks.

Edit: Oh, I see, it references LED1 Unless you guys want to add that file to the repo, I'll just change it for my device specifically whenever I get around to adding these to my repo.