Release.yml and text encoding improvements

MSzturc / ThinkpadAssistant

An Assistant Application that allows you to use all your Function Keys on a T-Series Thinkpad Laptop

122 stars 13 forks source link

Release.yml and text encoding improvements #42

Closed EETagent closed 4 years ago

EETagent commented 4 years ago

partially fixes #41

EETagent commented 4 years ago

Pull request is ready to be merged. Build log with app sign here

Getting this to work was really hell. GitHub Action was unable to get commits older than the latest one and I did not know why. with: fetch-depth: 0 is required to get whole git history. I also set UTF-8 as a default encoding for all localization files.

Snímek obrazovky 2020-08-04 v 1 59 45

EETagent commented 4 years ago

@MSzturc Before you merge it, it is possible to have your own username instead of github-actionson published release. For that, it is needed to have generated user token with repo checked, you can do that in account settings. After that you need to add generated hash to MY_TOKEN secret. If you would prefer that, I will add my latest commit with it to this pull request Snímek obrazovky 2020-08-05 v 11 56 26

MSzturc commented 4 years ago

I've generate an personal access token and added it to MY_TOKEN secret. Please add the needed code to the PR

EETagent commented 4 years ago

@MSzturc Added