ThinkpadAssistant for High Sierra

MSzturc / ThinkpadAssistant

An Assistant Application that allows you to use all your Function Keys on a T-Series Thinkpad Laptop

118 stars 13 forks source link

ThinkpadAssistant for High Sierra #50

Closed Charlyo closed 3 years ago

Charlyo commented 3 years ago

Dear @MSzturc, can this project be compiled for high sierra?

EETagent commented 3 years ago

@Charlyo

Currently not, ThinkPad Assistant uses properties introduced in macOS Mojave https://developer.apple.com/documentation/appkit/nsapplication/2967171-effectiveappearance?language=objc

Core functionality is definitely compatible, just not some UI stuff

Charlyo commented 3 years ago

Thank you for the update @EETagent. Is there any way to change the usage of those properties??

EETagent commented 3 years ago

Added some @available(macOS 10.14, *) checks and fallback to light theme when on High Sierra. Please try that, there might be a runtime error ( If there is some incompatibility undetected by compiler ) but I can't test that as I don't have 10.13

ThinkpadAssistant.zip

Charlyo commented 3 years ago

Thank you very much @EETagent !! The application works but the notifications take the whole screen.

EETagent commented 3 years ago

Thank you very much @EETagent !! The application works but the notifications take the whole screen.

Can you provide screenshot?

Charlyo commented 3 years ago

Sure, here you are!

EETagent commented 3 years ago

Sure, here you are!

Well, this is weird. I replaced Mojave checks with macOS 11 ones, to achieve same code behaviour as on High Sierra ( I am on Catalina currently ) and I was unable to reproduce your issue. override func updateLayer() is somewhat not executed on your machine.

With override func updateLayer() removed Snímek obrazovky 2020-10-14 v 10 50 42

I see that you might do not have GPU acceleration working. Your dock and ThinkPad Assistant HUD are not transparent. That might be a reason why this happens. Please fix that first

Charlyo commented 3 years ago

I do have the black theme (upper bar and dock) activated for High Sierra. However gonna test GPU acceleration again.

EETagent commented 3 years ago

By dark theme you mean defaults write -g NSWindowDarkChocolate -bool TRUE? Or some third party modification?

Charlyo commented 3 years ago

I haven't never set that up using terminal commands. Rather by general settings. Screen Shot 2020-10-15 at 19 54 17

Using white bar and dock actually shows the thinkpad assistant hud icon. Screen Shot 2020-10-15 at 19 55 30

EETagent commented 3 years ago

Would you try to execute this debug version using Terminal and post log? ThinkpadAssistant.app/Contents/MacOS/ThinkpadAssistant

ThinkpadAssistant.zip

EETagent commented 3 years ago

@Charlyo Actually, in the future ThinkPad Assistant is going to be replaced by YogaSMC. @zhen-zen even found way to use macOS's native OSD.

Charlyo commented 3 years ago

@EETagent Today I saw TogaSMC release 1.2.0. Should I migrate? I'm still curious if YogSMC can be used in high sierra. Will update to Catalina if strictly necessary.

Nonetheless, thank you for your previous answers.