Add support for setting the height, and using the installed theme colors of charts

MSzturc / obsidian-advanced-slides

Create markdown-based reveal.js presentations in Obsidian

https://mszturc.github.io/obsidian-advanced-slides/

MIT License

987 stars 82 forks source link

Add support for setting the height, and using the installed theme colors of charts #184

Closed KarstenB closed 1 year ago

KarstenB commented 1 year ago

Hi, I wanted to have the ability to use the theme colors (as it is supported by the charts plugin) for charts and their height. So I added this little piece of code that allows to add to new fields:

useThemeColors: true will check the --chart-color-X css styles to get the value for the corresponding bar
height: 400px will set the max-height attribute of the canvas to that number, allowing to have something different than full height.

Maybe that is something you want to integrate into the code, or maybe you know a better way of doing this.

Thanks for creating this plugin! It's really cool.

KarstenB commented 1 year ago

I just noted that you're using regex's for parsing yaml content. Is there any specific reason for doing so? I think it would make live a lot easier if the code block would be parsed with yaml to a json object.

MSzturc commented 1 year ago

I just noted that you're using regex's for parsing yaml content. Is there any specific reason for doing so? I think it would make live a lot easier if the code block would be parsed with yaml to a json object.

Yeah that's true, i guess when i've developed this part i've went the short route, feel free to change it and add another pull request.

MSzturc commented 1 year ago

Another nice addition would be an entry in the docs with a sample of using this new color map feature in advanced slides