search

MT-CTF / capturetheflag

Capture the Flag game using the Minetest Voxel Engine
https://ctf.rubenwardy.com
83 stars 90 forks source link

Add Death Message #1179

Open 165135 opened 1 year ago

165135 commented 1 year ago

Send death message to a player after they die telling them who killed them and who assisted in the kill. Can be toggled on and off in the Inventory Settings tab.

farooqkz commented 1 year ago

You are doing well young programmer ;)

165135 commented 1 year ago

I did not know that #n puts the PR link and name... I know now XD

165135 commented 1 year ago

image For some reason, its showing the setting multiple times

165135 commented 1 year ago

Okay, I think the three time setting register is because functions.lua is somehow running 3 times, possibly, idk if this is me understanding something wrong or intentional image

165135 commented 1 year ago

Oh I'm silly its called from the three gamemode init.luas

165135 commented 1 year ago

@farooqkz Did I miss something that needed to be changed?

farooqkz commented 1 year ago

@farooqkz Did I miss something that needed to be changed?

Just tested. It's almost okay. There is a small typo which I'm gonna make suggestion for it. after you committed my suggestion, I will mark it as ready for review.

farooqkz commented 1 year ago

@LoneWolfHT I haven't reviewed the code logic yet.

farooqkz commented 5 months ago

@165135 I tested this a long time ago. Does it also say how much score your killer got?

165135 commented 5 months ago

I didn't even remember that this existed but ok

LoneWolfHT commented 4 months ago

What do you think about also showing how many points were given for killing you? https://discord.com/channels/447819017391046687/1008040841102766153/1218686930833768612

Suggestion: On the death screen, show "<player_name> killed you for <points> points!"
LoneWolfHT commented 4 months ago

Oh, I guess #1306 already does that