MT-CTF / capturetheflag

Capture the Flag game using the Minetest Voxel Engine
https://ctf.rubenwardy.com
81 stars 88 forks source link

Adding 'all' option to `/r` #1186

Closed src4026 closed 1 year ago

src4026 commented 1 year ago

For reference: https://discord.com/channels/447819017391046687/1008040841102766153/1116006701636780184 Is this how I should do it, or is another way better?

src4026 commented 1 year ago

Why is it showing pname as undefined variable, although the code for it seems the same for me in the actual file and the one in this PR?

165135 commented 1 year ago

Why is it showing pname as undefined variable, although the code for it seems the same for me in the actual file and the one in this PR?

I think it is because pname isn't passed into the function get_rank directly, maybe try putting it as an argument

src4026 commented 1 year ago

Why is it showing pname as undefined variable, although the code for it seems the same for me in the actual file and the one in this PR?

I think it is because pname isn't passed into the function get_rank directly, maybe try putting it as an argument

Thanks! I'll mention it here too I guess :)

farooqkz commented 1 year ago

@src4026 Try this approach instead:

That is, you call the rank command function from itself. Please try and if you got lost, let me know :)

src4026 commented 1 year ago

Sure, thanks. I will try this approach and let you know :D 👍

src4026 commented 1 year ago

Ready for review.