Alterations to water and lava borders

MT-CTF / capturetheflag

Capture the Flag game using the Minetest Voxel Engine

https://ctf.rubenwardy.com

83 stars 88 forks source link

Alterations to water and lava borders #1218

Closed Emojigit closed 12 months ago

Emojigit commented 1 year ago

Two new commands are added:

/ctf_map fixborder: Selecting two coordinates, and then convert the old barriers within that area into their new variants.
/ctf_map setborder: Turn the selected area into the border. It works by looking up a reverse map of ctf_map.barrier_nodes.

LoneWolfHT commented 1 year ago

You can remove the air barrier code, but leave the new command

Emojigit commented 1 year ago

@LoneWolfHT Changes done. Ready for review.

LoneWolfHT commented 1 year ago

Might be worth adding a clearbarrier command to convert barrier nodes back. Doesn't have to be in this PR though

I'll rename border to barrier in your command names pre-merge unless you do that before me

Emojigit commented 1 year ago

Might be worth adding a clearbarrier command to convert barrier nodes back. Doesn't have to be in this PR though

I'll rename border to barrier in your command names pre-merge unless you do that before me

All these done. The clear barrier is basically the same as the old barrier removal logic, but only in the selected region.

Emojigit commented 12 months ago

This PR is also worth closing for a clearer commit history and target. I will review and probably rewrite the codes introduced in the PR before re-opening another PR.