Use voxel manip for barrier placing commands

MT-CTF / capturetheflag

Capture the Flag game using the Minetest Voxel Engine

https://ctf.rubenwardy.com

81 stars 87 forks source link

Use voxel manip for barrier placing commands #1265

Closed a-blob closed 1 month ago

a-blob commented 6 months ago

[x] This PR has been tested locally

appgurueu commented 4 months ago

Have you benchmarked that this is actually substantially faster? Barriers are a bit special because they are relatively sparse. VoxelManip can't offer sub-mapblock granularity. So with this PR, you'd be loading & setting at least 15 non-barrier blocks for each barrier block. This may very well offset any performance gains from using VoxelManip.

a-blob commented 4 months ago

The main problem with the current one is not speed, but that the barriers will have holes if a chunk within the selected area is not rendered when it's placing the barriers.

a-blob commented 1 month ago

@LoneWolfHT I think so