Fix bug - Poison grenades deal no damage to enemies.

MT-CTF / capturetheflag

Capture the Flag game using the Minetest Voxel Engine

https://ctf.rubenwardy.com

80 stars 85 forks source link

Fix bug - Poison grenades deal no damage to enemies. #1312

Closed mrtechtroid closed 1 week ago

mrtechtroid commented 2 weeks ago

[x] This PR has been tested locally
Due to damage amount being very low, 1 instead of 10, the poison grenade did not do damage at all to players.
Caused due to PR f847ac8

LoneWolfHT commented 1 week ago

That's punch_interval, the damage is down where fleshy=1 is. Maybe that needs to be increased to 2? A punch interval of 1 should be fine, it's accurate too

mrtechtroid commented 1 week ago

It does work(does damage as expected), when the punch_interval was increased to 10. However could you let me know of any alternative approaches to fix it.

farooqkz commented 1 week ago

hmm it works. Though I can't say why...

LoneWolfHT commented 1 week ago

It does work(does damage as expected), when the punch_interval was increased to 10. However could you let me know of any alternative approaches to fix it.

There might be an on_punchplayer or something that's ignoring 1hp damage with punch intervals of 1

What does 2hp of fleshy damage do?

mrtechtroid commented 1 week ago

Yes, punch interval 1, with fleshy = 2 also works, in fixing the issue.