Combat mode triggered even when not standing inside blocks

[appgurueu]

The check doesn't take different collisionboxes of slabs, stairs etc. into account at all. A proper implementation like https://github.com/appgurueu/modlib/blob/master/minetest/collisionboxes.lua must be used instead.

Note that the else branch will happily push combat time higher and higher while you're standing on slabs: https://github.com/MT-CTF/capturetheflag/blob/master/mods/ctf/ctf_combat/ctf_combat_mode/init.lua#L35

[savilli]

FIxed in 746c5c3bfd15ee530721b82feb4bcb854bc6633e

[appgurueu]

FIxed in 746c5c3

No, not fixed, rather hacked around (and only applying to water?).

The timer should still trigger if you're inside stairs/slabs, meaning there's no way around using collisionboxes for a clean solution.

[savilli]

Looks good to me