MT-CTF / ctf-discord-bot

A bot to manage roles and such on Discord

MIT License

7 stars 4 forks source link

Switch to TypeScript, fix #16 #17

Closed AFCMS closed 1 year ago

AFCMS commented 1 year ago

[x] Switch to TypeScript
[x] Fix https://github.com/MT-CTF/ctf-discord-bot/issues/16 ~~(waiting for Discord.js release, code prepared for it)~~ ~~- [ ] Implement some more features like #1 ?~~

@LoneWolfHT

LoneWolfHT commented 1 year ago

1 can be ignored for now

AFCMS commented 1 year ago

I will perhaps do more refactoring to prepare codebase to #16 and #18

AFCMS commented 1 year ago

Discord.js update juste landed

I will try to finish thé PR in the next few days

AFCMS commented 1 year ago

I looked into the possibility of using the global name or the server nickname instead of the username for the /x staff command. IDK what characters Minetest support compared to what is allowed in Discord, so I didn't implement this feature.

Anyway I consider this PR as ready for review @LoneWolfHT

LoneWolfHT commented 1 year ago

I looked into the possibility of using the global name or the server nickname instead of the username for the /x staff command. IDK what characters Minetest support compared to what is allowed in Discord, so I didn't implement this feature.

If you can strip out everything but a-zA-Z0-9_- from the names I think that'll be enough.

Anyway I consider this PR as ready for review @LoneWolfHT

It'll be a few more days before I can test. Thanks

AFCMS commented 1 year ago

Fixed a problem with the http server and used the nickname/globalname instead of the username when possible.