search

MTDOJRP / docs

KCDOJRP Official Documentation | https://docs.kcdojrp.com
https://docs.KCDOJRP.com
2 stars 9 forks source link

[BUG] Discord ID Not Found #49

Open Paneedah opened 4 months ago

Paneedah commented 4 months ago

In-Game Bug Report

Description

Sometimes upon join it'll state that it couldn't find a discord id. Other scripts seem to not have a problem.

Steps to Reproduce

Join the server.

Expected Behavior

It not to do that.

Screenshots

N/A

Additional Context

N/A

Your Environment

Paneedah commented 4 months ago

Potential Implementation / Fix

Modified the existing system to hopefully accommodate and not falsely kick players for 'No Discord ID Found'. This was done in 2 ways.

  1. Added a 1,000ms delay before trying to fetch identifiers.
  2. Implemented a system which marks players as 'dirty' when it fails to initially grab their discord id. This will force a re-fetch upon receiving the first heartbeat from the player.

Action: Moved to in-review for testing.

BurnhamR commented 4 months ago

Still persistent.

Paneedah commented 3 months ago

Fix part 1: 8ed6b92

Paneedah commented 3 months ago

Fix part 2: aee3048