MTES-MCT / camino

Le cadastre minier numérique ouvert
https://camino.beta.gouv.fr
GNU Affero General Public License v3.0
2 stars 2 forks source link

fix(ui): regagne les 5 points perdus sur mozilla observatory #1265

Closed MichaelBitard closed 2 days ago

MichaelBitard commented 1 week ago

Je pense que c'est à cause du header en double que ça faisait perdre 5 points (mais pas sûr) A tester dès que c'est déployé en dev

vmaubert commented 1 week ago

Sur la dev, je le vois même 3 fois.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.88%. Comparing base (ff0b46a) to head (b290196). Report is 3 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (ff0b46a) and HEAD (b290196). Click for more details.

HEAD has 8 uploads less than BASE | Flag | BASE (ff0b46a) | HEAD (b290196) | |------|------|------| |common|2|1| |ui|2|1| |api-unit|2|1| |api|4|1| |api-integration|2|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1265 +/- ## =========================================== - Coverage 79.48% 63.88% -15.60% =========================================== Files 772 772 Lines 92666 92666 Branches 6357 4914 -1443 =========================================== - Hits 73654 59199 -14455 - Misses 18883 33241 +14358 - Partials 129 226 +97 ``` | [Flag](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.94% <ø> (-40.44%)` | :arrow_down: | | [api-integration](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `?` | | | [api-unit](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.94% <ø> (ø)` | | | [common](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `95.57% <ø> (ø)` | | | [ui](https://app.codecov.io/gh/MTES-MCT/camino/pull/1265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `76.18% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MichaelBitard commented 1 week ago

Je regarde qui est capable de faire ça. J'ai l'impression que oauth2_proxy ne rajoute pas le header.

Peut-être le nginx-proxy